TIOBE - Java Coding Standard

Rule: Design18

Synopsis:	Avoid if (x != y) ..; else ..;
Language:	Java
Severity Level:	4
Category:	Design

Description:

In an "if" expression with an "else" clause, avoid negation in the test. For example, rephrase: if (x != y) diff(); else same(); as: if (x == y) same(); else diff(); Most "if (x != y)" cases without an "else" are often return cases, so consistent use of this rule makes the code easier to read. Also, this resolves trivial ordering problems, such as "does the error case go first?" or "does the common case go first?".

public class Foo {
 boolean bar(int x, int y) {
  return (x != y) ? diff : same;
 }
}